Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(lsp): auto-import types with 'import type' #25662

Merged
merged 1 commit into from
Sep 17, 2024
Merged

feat(lsp): auto-import types with 'import type' #25662

merged 1 commit into from
Sep 17, 2024

Conversation

nayeemrmn
Copy link
Collaborator

Closes #10776.

lucacasonato
lucacasonato approved these changes Sep 17, 2024
View reviewed changes
Copy link
Member

@lucacasonato lucacasonato left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great change! LGTM

@marvinhagemeister
Copy link
Contributor

Nice, been looking forward to this!

dsherret
dsherret approved these changes Sep 17, 2024
View reviewed changes
Copy link
Member

@dsherret dsherret left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM too.

@nayeemrmn nayeemrmn merged commit d4a0625 into denoland:main Sep 17, 2024
17 checks passed
@nayeemrmn nayeemrmn deleted the lsp-auto-import-type-modifier branch September 17, 2024 17:38
@nayeemrmn nayeemrmn mentioned this pull request Oct 25, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lucacasonato lucacasonato lucacasonato approved these changes

@dsherret dsherret dsherret approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

lsp: Auto import types as type
4 participants
@nayeemrmn @marvinhagemeister @dsherret @lucacasonato