Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: TypeScript 5.6 and npm:@types/node@22 #25614

Merged
merged 11 commits into from
Sep 14, 2024

Conversation

dsherret
Copy link
Member

@dsherret dsherret commented Sep 13, 2024

Closes #24238
Closes #23357

dsherret added a commit that referenced this pull request Sep 13, 2024
Extracted out of #25614

It's better for these to be non-minified because then diffs are better
when adding new versions.
@dsherret dsherret marked this pull request as ready for review September 13, 2024 14:37
Copy link
Contributor

@marvinhagemeister marvinhagemeister left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Member

@bartlomieju bartlomieju left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Possibly fixes #23357?

cli/tsc/dts/lib.webworker.d.ts Outdated Show resolved Hide resolved
cli/tsc/dts/lib.webworker.d.ts Outdated Show resolved Hide resolved
cli/tsc/dts/lib.webworker.d.ts Outdated Show resolved Hide resolved
@imcotton
Copy link

Can you also include fixing for Array.fromAsync from microsoft/TypeScript#59837?

It only got merged last week thus not picked by 5.6, but should be fixed asap I think.

@petamoriken
Copy link
Contributor

petamoriken commented Sep 13, 2024

This PR fixes #24238

I am trying to migrate the String#{is,to}WellFormed type to ES2024 (microsoft/TypeScript#58573). Anyway it has already been introduced as an ESNext type in TypeScript 5.6.

My bad, it has already been introduced to Deno!
https://github.com/denoland/deno/blob/main/cli/tsc/dts/lib.esnext.string.d.ts

@dsherret dsherret merged commit af2d992 into denoland:main Sep 14, 2024
17 checks passed
@dsherret dsherret deleted the typescript_5_6_take_three branch September 14, 2024 10:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

"".isWellFormed() doesn't type-check Iterator proposal type declarations are missing
5 participants