Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

BREAKING(io): remove Deno.Seeker[Sync] #25551

Merged
merged 3 commits into from
Sep 12, 2024
Merged

BREAKING(io): remove Deno.Seeker[Sync] #25551

merged 3 commits into from
Sep 12, 2024

Conversation

iuioiua
Copy link
Contributor

@iuioiua iuioiua commented Sep 10, 2024

Towards #22079

@iuioiua iuioiua marked this pull request as draft September 10, 2024 05:35
@iuioiua
Copy link
Contributor Author

iuioiua commented Sep 11, 2024

Note: this doesn't remove Deno.SeekMode. I could remove it also, but perhaps it's worth keeping for now, as the codebase itself and examples use Deno.SeekMode to a decent degree. Thoughts?

@iuioiua iuioiua marked this pull request as ready for review September 11, 2024 10:37
@iuioiua
Copy link
Contributor Author

iuioiua commented Sep 11, 2024

FYI @kt3k, this PR is blocked on a new version of std being published, which contains Seek[Sync] in @std/io/types.

This was referenced Sep 11, 2024
Merged
Closed
@iuioiua iuioiua enabled auto-merge (squash) September 12, 2024 12:21
@iuioiua iuioiua mentioned this pull request Sep 12, 2024
Merged
iuioiua added a commit that referenced this pull request Sep 12, 2024
@iuioiua
chore: update std submodule (#25595)
d656a26 
Unblocks #25551
@iuioiua iuioiua merged commit 0a4a8c7 into denoland:main Sep 12, 2024
16 checks passed
@iuioiua iuioiua deleted the remove-deno-seeker branch September 12, 2024 22:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lucacasonato lucacasonato lucacasonato approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@iuioiua @lucacasonato