feat(add): Add npm packages to package.json if present #25477
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I don't see a test for that so I assume this will be done in a follow up? |
bartlomieju
reviewed
Sep 6, 2024
bartlomieju
approved these changes
Sep 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #25321
Ended up being a larger refactoring, since we're now juggling (potentially) two config files in the same
add, instead of choosing one. I don't love the shape of the code, but I think it's good enoughSome smaller side improvements:
deno removesupportsjsoncdeno install --devwill be a really simple changedeno removeremoves the last import/dependency in theimports/dependencies/devDependenciesfield, it removes the field instead of leaving an empty object