Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: update hint for deno add <package> #25455

Merged
merged 2 commits into from
Sep 5, 2024
Merged

fix: update hint for deno add <package> #25455

merged 2 commits into from
Sep 5, 2024

Conversation

bartlomieju
Copy link
Member

Follow up to #25430

dsherret
dsherret approved these changes Sep 5, 2024
View reviewed changes
Copy link
Member

@dsherret dsherret left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Reason for doing this was an imprecise message:

error: Failed resolving types. Relative import path "@types/react" not prefixed with / or ./ or ../
  hint: If you want to use a JSR or npm package, try running `deno add @types/react`
    at ...

@bartlomieju bartlomieju merged commit 5dc907d into denoland:main Sep 5, 2024
17 checks passed
@bartlomieju bartlomieju deleted the update_add_hint branch September 5, 2024 09:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dsherret dsherret dsherret approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@bartlomieju @dsherret