Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Deprecate doc itests #25452

Merged
merged 7 commits into from
Sep 5, 2024
Merged

Conversation

MohammadSu1
Copy link
Contributor

chore: Deprecate doc itests.
This PR is part of solving #22907. In this PR, the doc_tests.rs file was deprecated, and all the tests were moved under specs/doc. Additionally, the related files under testdata/doc were removed after ensuring that they weren’t related to any other tests.

@CLAassistant
Copy link

CLAassistant commented Sep 5, 2024

CLA assistant check
All committers have signed the CLA.

@MohammadSu1
Copy link
Contributor Author

@dsherret Can you please review this change.

Copy link
Member

@dsherret dsherret left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks!!

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

(I updated these folders to not have a deno_doc_ prefix because there's already a doc folder)

@dsherret dsherret enabled auto-merge (squash) September 5, 2024 07:34
@dsherret dsherret merged commit 49340b9 into denoland:main Sep 5, 2024
17 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants