Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BREAKING(config): make supported compilerOptions an allow list #25432

Merged
merged 2 commits into from
Sep 4, 2024

Conversation

dsherret
Copy link
Member

@dsherret dsherret commented Sep 4, 2024

Deno has been using a deny list, which doesn't make sense because a lot of these options don't even work.

Closes #25363

Copy link
Member

@lucacasonato lucacasonato left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dsherret dsherret merged commit 07ad47d into denoland:main Sep 4, 2024
17 checks passed
@dsherret dsherret deleted the fix_compiler_options_allow_list branch September 4, 2024 15:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Allow-list flags in compilerOptions rather than deny-list them
2 participants