Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BREAKING(types): soft-remove Deno.run() #25403

Merged
merged 3 commits into from
Sep 4, 2024
Merged

Conversation

iuioiua
Copy link
Contributor

@iuioiua iuioiua commented Sep 3, 2024

Towards #22079

@iuioiua iuioiua changed the title BREAKING: soft-remove Deno.run() chore: soft-remove Deno.run() Sep 3, 2024
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Missed in #25371

*
* Deno.kill(p.pid, "SIGINT");
* Deno.kill(child.pid, "SIGINT");
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@dsherret dsherret changed the title chore: soft-remove Deno.run() BREAKING(types): soft-remove Deno.run() Sep 4, 2024
Copy link
Member

@dsherret dsherret left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@iuioiua iuioiua merged commit 195b17a into denoland:main Sep 4, 2024
17 checks passed
@iuioiua iuioiua deleted the remove-deno-run branch September 4, 2024 22:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants