-
Notifications
You must be signed in to change notification settings - Fork 5.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(cli): give access to process
global everywhere
#25291
Conversation
ext/node/global.rs
Outdated
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What do we do with the TypeScript types?
I think we probably want to add our own type for process
and then maybe if the user imports @types/node
it will start using that process
global instead (this is pretty trivial for me to implement)? For now, we can just add our own type.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think maybe we should merge without typescript types for now?
Is the intent of this implementation some kind of requirement that cannot be met by |
|
Admittedly, I'm glad to hear that exposing global variables is intended to improve compatibility with Node.js. I heard that Deno's Node.js compatibility works by internally determining whether or not it is in compatibility mode. I really wanted to hear it. Thanks! |
This would close #24978 (and others...) |
8874bae
to
7244ee0
Compare
What do we do with the TypeScript types?