test: run node_unit_tests with DENO_FUTURE=1
#25285
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dsherret
reviewed
Aug 28, 2024
| @@ -64,6 +64,9 @@ Deno.test({ | |||
|
|
|||
| Deno.test({ | |||
| name: "Async: Data is written to passed in rid", | |||
| // TODO(bartlomieju): this test is broken in Deno 2, because `file.rid` is undefined. | |||
There was a problem hiding this comment.
I'm concerned about these TODOs being lost and not taken care of before the release. Maybe we should label them like TODO(2.0)?
There was a problem hiding this comment.
I'll link back that PR in the issue.
There was a problem hiding this comment.
But the test was previously passing and now it's not?
There was a problem hiding this comment.
I wasn't thinking. This seems find to me.
iuioiua
approved these changes
Aug 28, 2024
iuioiua
changed the title
node_unit_tests with DENO_FUTURE=1
dsherret
approved these changes
Aug 28, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is blocking #25213.
Turns out a bunch of FS APIs are completely broken because they
use RIDs (resource IDs) instead of FDs (file descriptors).