Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(ext/kv): configurable limit params #25174

Merged

Conversation

magurotuna
Copy link
Member

This commit makes various limit parameters in deno_kv configurable.

Currently these values are declared as constants and thus can't be modified from outside. However, there may be situations where we want to change it. This commit makes this possible by introducing a new struct KvConfig that needs to be given as the 2nd param in init_ops.

@magurotuna magurotuna force-pushed the ext-kv-configurable-limit-params branch from ef92f52 to 23e072d Compare August 23, 2024 07:10
Copy link
Member

@losfair losfair left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@magurotuna magurotuna merged commit 9b40265 into denoland:main Aug 27, 2024
17 checks passed
@magurotuna magurotuna deleted the ext-kv-configurable-limit-params branch August 27, 2024 07:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants