Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: remove Deno.metrics() #25167

Merged
merged 4 commits into from
Aug 30, 2024
Merged

chore: remove Deno.metrics() #25167

merged 4 commits into from
Aug 30, 2024

Conversation

iuioiua
Copy link
Contributor

@iuioiua iuioiua commented Aug 23, 2024 •
edited
Loading

On Deploy, this symbol returns {} but is not documented (ref).

Note: we need to remove metrics() from deno_core after this.

Towards #22079

@iuioiua iuioiua marked this pull request as ready for review August 23, 2024 00:41
@iuioiua iuioiua mentioned this pull request Aug 28, 2024
Closed
bartlomieju
bartlomieju approved these changes Aug 30, 2024
View reviewed changes
Copy link
Member

@bartlomieju bartlomieju left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@bartlomieju
Copy link
Member

Please remove BREAKING from the PR title. It's not breaking, it's a chore, since the actual API was removed for users in b1c6142

@iuioiua iuioiua changed the title BREAKING: remove Deno.metrics() chore: remove Deno.metrics() Aug 30, 2024
@iuioiua iuioiua merged commit 504ae36 into denoland:main Aug 30, 2024
17 checks passed
@iuioiua iuioiua deleted the remove-deno-metrics-2 branch August 30, 2024 22:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bartlomieju bartlomieju bartlomieju approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@iuioiua @bartlomieju