fix: warn about import assertions when using typescript #25135
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
dsherret
commented
Aug 21, 2024
dsherret
commented
- On emit, checks for the prescence of import assertions.
- Warns and doesn't store the parsed source in the emit cache in this case.
bartlomieju
reviewed
Aug 21, 2024
Comment on lines
+330
to
+334
| for item in &module.body { | ||
| match item { | ||
| deno_ast::swc::ast::ModuleItem::ModuleDecl(decl) => match decl { | ||
| deno_ast::swc::ast::ModuleDecl::Import(n) => { | ||
| if n.with.is_some() |
There was a problem hiding this comment.
Can you also handle import("./data.json", { assert: { type: "json" }})?
There was a problem hiding this comment.
Oh, that's annoying. I'll update it.
There was a problem hiding this comment.
We don't need to do it for that because v8 will warn about it.
bartlomieju
approved these changes
Aug 21, 2024
littledivy
approved these changes
Aug 21, 2024
It's probably not worth the trouble. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.