Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: node:inspector not being registered #25007

Merged
merged 6 commits into from
Aug 14, 2024
Merged

Conversation

marvinhagemeister
Copy link
Contributor

For some reason we didn't register the node:inspector module, which lead to a panic when trying to import it. This PR registers it.

Related: #25004

@marvinhagemeister
Copy link
Contributor Author

Hm getting this error:

  --- stderr
  WARNING: v8::OwnedIsolate for snapshot was leaked
  thread 'main' panicked at /Users/marvinh/.cargo/registry/src/index.crates.io-6f17d22bba15001f/deno_core-0.303.0/runtime/jsruntime.rs:2071:9:
  Failed to initialize JsRuntime for snapshotting: Following modules were not evaluated; make sure they are imported from other code:
     - node:inspector

@marvinhagemeister marvinhagemeister marked this pull request as draft August 12, 2024 15:58
@marvinhagemeister marvinhagemeister marked this pull request as ready for review August 14, 2024 11:06
Copy link
Member

@littledivy littledivy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@marvinhagemeister marvinhagemeister enabled auto-merge (squash) August 14, 2024 12:30
@marvinhagemeister marvinhagemeister merged commit 533d31b into main Aug 14, 2024
17 checks passed
@marvinhagemeister marvinhagemeister deleted the node-inspector branch August 14, 2024 12:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants