-
Notifications
You must be signed in to change notification settings - Fork 5.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: deno remove #24952
feat: deno remove #24952
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I just tried it. Works great with both deno.json
and package.json
.
One thing I noticed: if I add with deno add npm:chalk
, I can't remove with deno rm npm:chalk
; I have to use deno rm chalk
. Not a big deal, but I think we could improve it further in the future.
LGTM!
Signed-off-by: Satya Rohith <[email protected]>
@satyarohith I want to take another look at this on Monday. I'll merge it then. |
if cli_factory.cli_options()?.enable_future_features() { | ||
crate::module_loader::load_top_level_deps(&cli_factory).await?; | ||
} | ||
crate::module_loader::load_top_level_deps(&cli_factory).await?; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@bartlomieju do you know why we feature gated this? I feel like we should be running this even without DENO_FUTURE?
No description provided.