Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: rename watch event missing #24893

Merged
merged 7 commits into from
Aug 7, 2024
Merged

fix: rename watch event missing #24893

merged 7 commits into from
Aug 7, 2024

Conversation

marvinhagemeister
Copy link
Contributor

@marvinhagemeister marvinhagemeister commented Aug 5, 2024 •
edited
Loading

This PR ensures that we forward a rename event in our file watcher. The rust lib we use combines that with the modify event.

This fixes a compatibility issue with Node too, which sends the rename event as well.

Fixes #24880

@marvinhagemeister marvinhagemeister marked this pull request as draft August 5, 2024 15:56
@marvinhagemeister marvinhagemeister marked this pull request as ready for review August 5, 2024 16:22
lucacasonato
lucacasonato approved these changes Aug 7, 2024
View reviewed changes
Copy link
Member

@lucacasonato lucacasonato left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@marvinhagemeister marvinhagemeister merged commit 9d6da10 into main Aug 7, 2024
17 checks passed
@marvinhagemeister marvinhagemeister deleted the watch-rename branch August 7, 2024 16:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lucacasonato lucacasonato lucacasonato approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Bug: Deno.watchFs doesn't detect a file rename/move
2 participants
@marvinhagemeister @lucacasonato