Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(types): fix streams types #24770

Merged
merged 4 commits into from
Jul 29, 2024
Merged

fix(types): fix streams types #24770

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
c73c1a1
fix `ReadableStreamDefaultControllerCallback` type
petamoriken Jul 28, 2024
42c8149
conform `ReadableStream` constructor type to upstream
petamoriken Jul 28, 2024
1f58a23
tweak
petamoriken Jul 28, 2024
c10975a
ci
petamoriken Jul 28, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion cli/tsc/dts/lib.dom.d.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18823,7 +18823,7 @@ interface ReadableStream<R = any> {

declare var ReadableStream: {
prototype: ReadableStream;
new(underlyingSource: UnderlyingByteSource, strategy?: { highWaterMark?: number; size?: undefined }): ReadableStream<Uint8Array>;
new(underlyingSource: UnderlyingByteSource, strategy?: { highWaterMark?: number }): ReadableStream<Uint8Array>;
new<R = any>(underlyingSource: UnderlyingDefaultSource<R>, strategy?: QueuingStrategy<R>): ReadableStream<R>;
new<R = any>(underlyingSource?: UnderlyingSource<R>, strategy?: QueuingStrategy<R>): ReadableStream<R>;
from<R>(asyncIterable: AsyncIterable<R> | Iterable<R | PromiseLike<R>>): ReadableStream<R>;
Expand Down
2 changes: 1 addition & 1 deletion cli/tsc/dts/lib.webworker.d.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4882,7 +4882,7 @@ interface ReadableStream<R = any> {

declare var ReadableStream: {
prototype: ReadableStream;
new(underlyingSource: UnderlyingByteSource, strategy?: { highWaterMark?: number; size?: undefined }): ReadableStream<Uint8Array>;
new(underlyingSource: UnderlyingByteSource, strategy?: { highWaterMark?: number }): ReadableStream<Uint8Array>;
new<R = any>(underlyingSource: UnderlyingDefaultSource<R>, strategy?: QueuingStrategy<R>): ReadableStream<R>;
new<R = any>(underlyingSource?: UnderlyingSource<R>, strategy?: QueuingStrategy<R>): ReadableStream<R>;
from<R>(asyncIterable: AsyncIterable<R> | Iterable<R | PromiseLike<R>>): ReadableStream<R>;
Expand Down
19 changes: 10 additions & 9 deletions ext/web/lib.deno_web.d.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -731,14 +731,6 @@ declare interface UnderlyingSourceCancelCallback {
(reason?: any): void | PromiseLike<void>;
}

// TODO(petamoriken): Will be removed in v2.0.
/**
* @deprecated use `UnderlyingSourcePullCallback` instead.
* @category Streams
*/
declare type ReadableStreamDefaultControllerCallback<R> =
UnderlyingSourcePullCallback<R>;

/** @category Streams */
declare interface UnderlyingSourcePullCallback<R> {
(controller: ReadableStreamController<R>): void | PromiseLike<void>;
Expand All @@ -749,6 +741,15 @@ declare interface UnderlyingSourceStartCallback<R> {
(controller: ReadableStreamController<R>): any;
}

// TODO(petamoriken): Will be removed in v2.0.
/**
* @deprecated use `(controller: ReadableStreamDefaultController<R>) => void | PromiseLike<void>` type instead.
* @category Streams
*/
declare type ReadableStreamDefaultControllerCallback<R> = (
controller: ReadableStreamDefaultController<R>,
) => void | PromiseLike<void>;

/** @category Streams */
declare interface ReadableStreamDefaultController<R = any> {
readonly desiredSize: number | null;
Expand Down Expand Up @@ -877,7 +878,7 @@ declare var ReadableStream: {
readonly prototype: ReadableStream;
new (
underlyingSource: UnderlyingByteSource,
strategy?: { highWaterMark?: number; size?: undefined },
strategy?: { highWaterMark?: number },
): ReadableStream<Uint8Array>;
new <R = any>(
underlyingSource: UnderlyingDefaultSource<R>,
Expand Down