Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(unstable/compile): handle byonm import in sub dir #24755

Merged
merged 2 commits into from
Jul 26, 2024
Merged

fix(unstable/compile): handle byonm import in sub dir #24755

merged 2 commits into from
Jul 26, 2024

Conversation

dsherret
Copy link
Member

@dsherret dsherret commented Jul 26, 2024 •
edited
Loading

Regression in 1.45.0 caused by storing relative paths instead of absolute paths in the binary.

Closes #24654

@dsherret dsherret changed the title fix(compile/byonm): handle entrypoint in sub dir fix(unstable/compile): handle byonm import in sub dir Jul 26, 2024
@dsherret dsherret merged commit 06b6352 into denoland:main Jul 26, 2024
17 checks passed
@dsherret dsherret deleted the fix_byonm_compile_sub_dir branch July 26, 2024 19:53
crowlKats pushed a commit that referenced this pull request Jul 31, 2024
@dsherret @crowlKats
fix(unstable/compile): handle byonm import in sub dir (#24755)
1a87be7 
Regression in 1.45.0 caused by storing relative paths instead of
absolute paths in the binary.

Closes #24654

(cherry picked from commit 06b6352)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@marvinhagemeister marvinhagemeister marvinhagemeister approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[complie] Importing node modules does not work with byonm flag when entrypoint in a sub dir
2 participants
@dsherret @marvinhagemeister