feat: upgrade V8 to 12.8 #24693
Merged
feat: upgrade V8 to 12.8 #24693
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
devsnek
commented
Jul 24, 2024
•
devsnek
commented
- upgrade to v8 12.8
- optimizes DataView bigint methods
- fixes global interceptors
- includes CPED methods for ALS
- fix global resolution
- makes global resolution consistent using host_defined_options. originally a separate patch but due to the global interceptor bug it needs to be included in this pr for all tests to pass.
devsnek
force-pushed
the
upgrade-v8
branch
6 times, most recently
from
4db1498
to
6e6c160
Compare
dsherret
reviewed
Jul 29, 2024
|
Let's change the title to |
|
Please rebase |
bartlomieju
reviewed
Jul 31, 2024
ext/node/lib.rs
Outdated
| @@ -836,3 +836,12 @@ impl<'a> deno_package_json::fs::DenoPkgJsonFs for DenoPkgJsonFsAdapter<'a> { | |||
| .map_err(|err| err.into_io_error()) | |||
| } | |||
| } | |||
|
|
|||
| pub fn get_host_defined_options<'s>( | |||
There was a problem hiding this comment.
Shouldn't this one be named create_host_defined_options?
| let source = v8::script_compiler::Source::new(source_str, None); | ||
| let resource_name = v8::undefined(scope); | ||
| let host_defined_options = get_host_defined_options(scope); | ||
| let origin = v8::ScriptOrigin::new( |
There was a problem hiding this comment.
Can we please a new API for v8::ScriptOrigin? 🙏 It should accept a scope and an options struct, with only resource_name being required.
bartlomieju
approved these changes
Jul 31, 2024
ext/node/polyfills/01_require.js
Outdated
| const compiledWrapper = wrapSafe(filename, content, this, format); | ||
|
|
||
| if (format === "module") { | ||
| // TODO: implement require esm |
There was a problem hiding this comment.
Can you please open an issue and link it here?
ext/node/polyfills/01_require.js
Outdated
| if (StringPrototypeEndsWith(filename, ".js")) { | ||
| const pkg = op_require_read_closest_package_json(filename); | ||
| if (pkg && pkg.typ === "module") { | ||
| if (pkg?.typ === "module") { | ||
| // TODO: implement require esm |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.