-
Notifications
You must be signed in to change notification settings - Fork 5.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: clean up permission / unstable flag help output #24686
Merged
crowlKats
merged 28 commits into
main
from
hide_unstable_and_granular_permissions_by_default
Aug 18, 2024
Merged
fix: clean up permission / unstable flag help output #24686
crowlKats
merged 28 commits into
main
from
hide_unstable_and_granular_permissions_by_default
Aug 18, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
You can see them with `DENO_PERMISSION_HELP=1` and `DENO_UNSTABLE_HELP=1`.
lucacasonato
changed the title
fix: don't show granular unstable and permission flags by default
fix: clean up permission / unstable flag help output
Jul 24, 2024
…fault # Conflicts: # cli/args/flags.rs
…er alphabetically
…fault # Conflicts: # cli/args/flags.rs
…fault # Conflicts: # cli/args/flags.rs
bartlomieju
approved these changes
Aug 18, 2024
crowlKats
deleted the
hide_unstable_and_granular_permissions_by_default
branch
August 18, 2024 22:39
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Permission flags are unified in a clearer and concise output.
Unstable flags are hidden by default with exception of the
unstable
flag itself. the remaining unstable flags can be seen with a--help=unstable
.This also cleans up to show unstable flags only for subcommands that actually need them.
Also sorts flags alphabetically, and gorups various flags together in a set of categories.
Before:
After: