Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: make vendor cache manifest more deterministic #24658

Merged
merged 1 commit into from
Jul 21, 2024

Conversation

zebreus
Copy link
Contributor

@zebreus zebreus commented Jul 20, 2024

This PR will bump the deno_cache_dir dependency from 0.10.0 to 0.10.2. This will make the cache manifest at manifest.json more deterministic (see denoland/deno_cache_dir#53 )

@dsherret dsherret changed the title refactor: update deno_cache_dir dependency to 0.10.2 fix: make vendor cache manifest more deterministic Jul 21, 2024
Copy link
Member

@dsherret dsherret left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@dsherret dsherret enabled auto-merge (squash) July 21, 2024 03:50
@dsherret dsherret merged commit bb1c6c4 into denoland:main Jul 21, 2024
17 checks passed
bartlomieju pushed a commit that referenced this pull request Jul 22, 2024
This PR will bump the deno_cache_dir dependency from 0.10.0 to 0.10.2.
This will make the cache manifest at manifest.json more deterministic
(see denoland/deno_cache_dir#53 )

<!--
Before submitting a PR, please read
https://docs.deno.com/runtime/manual/references/contributing

1. Give the PR a descriptive title.

  Examples of good title:
    - fix(std/http): Fix race condition in server
    - docs(console): Update docstrings
    - feat(doc): Handle nested reexports

  Examples of bad title:
    - fix #7123
    - update docs
    - fix bugs

2. Ensure there is a related issue and it is referenced in the PR text.
3. Ensure there are tests that cover the changes.
4. Ensure `cargo test` passes.
5. Ensure `./tools/format.js` passes without changing files.
6. Ensure `./tools/lint.js` passes.
7. Open as a draft PR if your work is still in progress. The CI won't
run
   all steps, but you can add '[ci]' to a commit message to force it to.
8. If you would like to run the benchmarks on the CI, add the 'ci-bench'
label.
-->
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants