fix(cli): Respect implied BYONM from DENO_FUTURE in deno task
#24652
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Regression from 04f9db5
Originally I thought to fix the issue in the PR we needed to explicitly pass through the
node-modules-dir
flag, but after applying the correct fix that david pointed out (settingNPM_PROCESS_STATE
) that wasn't necessary (or correct).We had a test for deno task with BYONM, but it only tested with
"unstable": ["byonm"]
in deno.json, so it didn't catch this.