-
Notifications
You must be signed in to change notification settings - Fork 5.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(cli): Create child node_modules for conflicting dependency versions, respect aliases in package.json #24609
fix(cli): Create child node_modules for conflicting dependency versions, respect aliases in package.json #24609
Conversation
let dest_path = | ||
remote.base_dir.join("node_modules").join(&remote.alias); | ||
|
||
symlink_package_dir(&local_registry_package_path, &dest_path)?; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should probably add to the setup cache
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Very nice! This looks good to me, but I'm not sure why the CI is failing because of it.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! Thanks!
Fixes #24419.