Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(ext/webgpu): GPUDevice.createRenderPipelineAsync should return a Promise #24349

Merged
merged 1 commit into from
Jul 12, 2024
Merged

fix(ext/webgpu): GPUDevice.createRenderPipelineAsync should return a Promise #24349

merged 1 commit into from
Jul 12, 2024

Conversation

chirsz-ever
Copy link
Contributor

@chirsz-ever chirsz-ever commented Jun 26, 2024 •
edited
Loading

fix #24317

littledivy
littledivy approved these changes Jul 12, 2024
View reviewed changes
Copy link
Member

@littledivy littledivy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@littledivy littledivy merged commit 01c074d into denoland:main Jul 12, 2024
17 checks passed
dsherret pushed a commit that referenced this pull request Jul 12, 2024
@chirsz-ever @dsherret
fix(ext/webgpu): GPUDevice.createRenderPipelineAsync should return a …
247513e 
…Promise (#24349)

Fixes #24317
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@littledivy littledivy littledivy approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

WebGPU: GPUDevice.createRenderPipelineAsync not return a Promise
2 participants
@chirsz-ever @littledivy