Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(napi): Read reference ownership before calling finalizer to avoid crash #24203

Merged
merged 3 commits into from
Jun 13, 2024
Merged

fix(napi): Read reference ownership before calling finalizer to avoid crash #24203

merged 3 commits into from
Jun 13, 2024

Commits on Jun 13, 2024

  1. Add regression test

    @nathanwhit
    nathanwhit committed Jun 13, 2024
    Configuration menu
    Copy the full SHA
    a69623b View commit details
    Browse the repository at this point in the history

  2. Copy ownership before finalize cb

    @nathanwhit
    nathanwhit committed Jun 13, 2024
    Configuration menu
    Copy the full SHA
    a3c6fd5 View commit details
    Browse the repository at this point in the history

  3. Remove unnecessary flag

    @nathanwhit
    nathanwhit committed Jun 13, 2024
    Configuration menu
    Copy the full SHA
    193c18a View commit details
    Browse the repository at this point in the history