Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(ext/node): support throwIfNoEntry option in fs.lstatSync #24006

Merged
merged 1 commit into from
May 28, 2024

Conversation

marvinhagemeister
Copy link
Contributor

We didn't support the throwIfNoEntry option for Node's fs.lstatSync method. Note that the async variant doesn't have this option.

Fixes #23996

Copy link
Member

@kt3k kt3k left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@marvinhagemeister marvinhagemeister merged commit a0ddf73 into main May 28, 2024
17 checks passed
@marvinhagemeister marvinhagemeister deleted the node-lstatsync branch May 28, 2024 10:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

node compat: lstatSync missing throwIfNoEntry
2 participants