Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: empty process.platform with __runtime_js_sources #24005

Merged
merged 2 commits into from
May 28, 2024
Merged

fix: empty process.platform with __runtime_js_sources #24005

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
835dc11
fix: empty `process.platform` with `__runtime_js_sources`
marvinhagemeister May 28, 2024
9d464cc
chore: remove to_owned()
marvinhagemeister May 28, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 10 additions & 1 deletion runtime/ops/bootstrap.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -42,11 +42,20 @@ pub struct SnapshotOptions {

impl Default for SnapshotOptions {
fn default() -> Self {
let arch = std::env::consts::ARCH;
let platform = std::env::consts::OS;
let target = match platform {
"macos" => format!("{}-apple-darwin", arch),
"linux" => format!("{}-unknown-linux-gnu", arch),
"windows" => format!("{}-pc-windows-msvc", arch),
rest => format!("{}-{}", arch, rest),
};

Self {
deno_version: "dev".to_owned(),
ts_version: "n/a".to_owned(),
v8_version: deno_core::v8_version(),
target: std::env::consts::ARCH.to_owned(),
target,
}
}
}
Expand Down