Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(serve): support --port 0 to use an open port #23846

Merged
merged 3 commits into from
May 17, 2024
Merged

feat(serve): support --port 0 to use an open port #23846

merged 3 commits into from
May 17, 2024
+96 −16

Conversation

satyarohith
Copy link
Member

Closes #23845

@satyarohith satyarohith marked this pull request as ready for review May 16, 2024 13:01
@satyarohith satyarohith requested review from mmastrac and bartlomieju and removed request for mmastrac May 16, 2024 13:01
@satyarohith satyarohith mentioned this pull request May 16, 2024
Merged
@satyarohith satyarohith enabled auto-merge (squash) May 16, 2024 14:22
@satyarohith satyarohith disabled auto-merge May 16, 2024 15:00
@satyarohith satyarohith enabled auto-merge (squash) May 16, 2024 15:00
@bartlomieju bartlomieju disabled auto-merge May 16, 2024 21:00
bartlomieju
bartlomieju approved these changes May 16, 2024
View reviewed changes
Copy link
Member

@bartlomieju bartlomieju left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

cli/args/flags.rs Show resolved Hide resolved
@satyarohith satyarohith enabled auto-merge (squash) May 17, 2024 05:13
@satyarohith satyarohith merged commit 20cb0e8 into denoland:main May 17, 2024
17 checks passed
@satyarohith satyarohith deleted the support_port_0_deno_serve branch May 17, 2024 05:42
bartlomieju pushed a commit that referenced this pull request May 21, 2024
@satyarohith @bartlomieju
feat(serve): support --port 0 to use an open port (#23846)
65a7d34 
Closes #23845
@bartlomieju bartlomieju mentioned this pull request May 23, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mmastrac mmastrac mmastrac left review comments

@bartlomieju bartlomieju bartlomieju approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

deno serve should support --port 0
3 participants
@satyarohith @mmastrac @bartlomieju