Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(lsp): show reference code lens on methods #23804

Merged
merged 1 commit into from
May 14, 2024
Merged

fix(lsp): show reference code lens on methods #23804

merged 1 commit into from
May 14, 2024

Conversation

nayeemrmn
Copy link
Collaborator

nathanwhit
nathanwhit approved these changes May 14, 2024
View reviewed changes
Copy link
Member

@nathanwhit nathanwhit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

dsherret
dsherret approved these changes May 14, 2024
View reviewed changes
Copy link
Member

@dsherret dsherret left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM too

@nayeemrmn nayeemrmn merged commit dda8979 into denoland:main May 14, 2024
17 checks passed
@nayeemrmn nayeemrmn deleted the lsp-code-lens-method-references branch May 15, 2024 00:57
@CalvinWilkinson
Copy link

Great work guys!!

bartlomieju pushed a commit that referenced this pull request May 16, 2024
@nayeemrmn @bartlomieju
fix(lsp): show reference code lens on methods (#23804)
8ce9aa5
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nathanwhit nathanwhit nathanwhit approved these changes

@dsherret dsherret dsherret approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Code lens does not work
4 participants
@nayeemrmn @CalvinWilkinson @dsherret @nathanwhit