Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(test): proper type checking for files with doc tests #23654

Merged
merged 5 commits into from
May 2, 2024
Merged

fix(test): proper type checking for files with doc tests #23654

merged 5 commits into from
May 2, 2024

Conversation

crowlKats
Copy link
Member

Closes #23430

@crowlKats crowlKats requested a review from dsherret May 2, 2024 12:00
dsherret
dsherret reviewed May 2, 2024
View reviewed changes
cli/tools/test/mod.rs Outdated Show resolved Hide resolved
dsherret
dsherret approved these changes May 2, 2024
View reviewed changes
Copy link
Member

@dsherret dsherret left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@crowlKats crowlKats enabled auto-merge (squash) May 2, 2024 18:00
@crowlKats crowlKats merged commit 1b27b58 into denoland:main May 2, 2024
17 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dsherret dsherret dsherret approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

--doc option seems disabling type checking
2 participants
@crowlKats @dsherret