FUTURE: initial support for .npmrc file #23560
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bartlomieju
added a commit
that referenced
this pull request
Apr 26, 2024
Factored out from #23560 to make it easier to review.
cli/http_util.rs
Outdated
Comment on lines
361
to
365
| let mut builder = self.get_no_redirect(new_url.clone())?; | ||
| if let Some((header_name, header_value)) = maybe_header.as_ref() { | ||
| builder = builder.header(header_name, header_value); | ||
| } | ||
| let new_response = builder.send().await?; |
There was a problem hiding this comment.
You should only serve auth tokens after a redirect if the original and redirected URL have the same origin.
bartlomieju
force-pushed
the
npm_private_registry
branch
from
66708ec
to
e1a9606
Compare
dsherret
reviewed
May 14, 2024
| .unwrap(); | ||
| let mut relative_url = registry_root_dir.make_relative(specifier)?; | ||
| if relative_url.starts_with("../") { | ||
| return None; |
There was a problem hiding this comment.
I think we could make this more optimal by storing root_url_to_safe_local_dirname for each registry url in the constructor, then here getting the relative path from the self.root_dir_url, then check the first component for a match, then continue below
bartlomieju
commented
May 14, 2024
There was a problem hiding this comment.
It appears --reload flag is not working correctly if .npmrc is present and custom registries are used.
This is a blocker to landing this PR. Opened #23953 to address in a follow up
bartlomieju
changed the title
This was referenced May 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit adds initial support for ".npmrc" files.
Currently we only discover ".npmrc" files next to "package.json" files
and discovering these files in user home dir is left for a follow up.
This pass supports "_authToken" and "_auth" configuration
for providing authentication.
LSP support has been left for a follow up PR.
Towards #16105