Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: infer dependencies from package.json #22563

Merged
merged 5 commits into from
Feb 23, 2024
Merged

feat: infer dependencies from package.json #22563

merged 5 commits into from
Feb 23, 2024

Conversation

marvinhagemeister
Copy link
Contributor

This PR enhances the deno publish command to infer dependencies from package.json if present.

marvinhagemeister
marvinhagemeister commented Feb 23, 2024
View reviewed changes
tests/util/server/src/lib.rs
vec![
("NPM_CONFIG_REGISTRY".to_string(), npm_registry_url()),
("JSR_URL".to_string(), jsr_registry_url()),
("NO_COLOR".to_string(), "1".to_string()),
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Had to add a new function because we need both the npm env + jsr env.

lucacasonato
lucacasonato reviewed Feb 23, 2024
View reviewed changes
Copy link
Member

@lucacasonato lucacasonato left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

With the local registry in the tests, we pull tarballs from the folders in tests/testdata/npm/registry/.

chalk is already in there, so if you use that instead of camelcase, you do not need to check in the node_modules/ folder.

lucacasonato
lucacasonato approved these changes Feb 23, 2024
View reviewed changes
Copy link
Member

@lucacasonato lucacasonato left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@marvinhagemeister marvinhagemeister merged commit cddefec into main Feb 23, 2024
17 checks passed
@marvinhagemeister marvinhagemeister deleted the publish_package_json branch February 23, 2024 14:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lucacasonato lucacasonato lucacasonato approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@marvinhagemeister @lucacasonato