fix(ext/node): pass alpnProtocols to Deno.startTls #22512
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bartlomieju
approved these changes
Feb 21, 2024
Comment on lines
+217
to
+218
| // TODO(satyarohith): create goaway op and pass the args | ||
| debugHttp2(">>> goaway - ignored args", code, lastStreamID, opaqueData); |
There was a problem hiding this comment.
This is gonna be hard - last time I tried it, h2/hyper didn't allow to explicitly send goaway frame :(
There was a problem hiding this comment.
Yeah. I found that frame module is public under unstable feature flag but I need to check whether send_data() on SendStream allows us to send single frames (it does allow sending data frames but not sure about goaway).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #22479