Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(ext/node): unimplemented code when not IPC child_process #22488

Merged
merged 1 commit into from
Feb 20, 2024
Merged

fix(ext/node): unimplemented code when not IPC child_process #22488

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion ext/node/polyfills/internal/child_process.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -300,7 +300,9 @@ export class ChildProcess extends EventEmitter {
}

/* Cancel any pending IPC I/O */
this.disconnect?.();
if (this.implementsDisconnect) {
this.disconnect?.();
}

this.killed = true;
this.signalCode = denoSignal;
Expand Down Expand Up @@ -1148,6 +1150,7 @@ export function setupChannel(target, ipc) {
target.emit("disconnect");
});
};
target.implementsDisconnect = true;

// Start reading messages from the channel.
readLoop();
Expand Down