feat(lsp): cache jsxImportSource automatically #21687
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nayeemrmn
commented
Dec 22, 2023
bartlomieju
reviewed
Dec 23, 2023
dsherret
reviewed
Dec 28, 2023
dsherret
reviewed
Dec 29, 2023
bartlomieju
approved these changes
Jan 2, 2024
Comment on lines
+1070
to
+1073
| if let Some(config_file) = self.config.maybe_config_file() { | ||
| if let Ok((compiler_options, _)) = config_file.to_compiler_options() { | ||
| if let Some(compiler_options_obj) = compiler_options.as_object() { | ||
| if let Some(jsx_import_source) = |
There was a problem hiding this comment.
Nitpick, but all of this should be simplified using let else
There was a problem hiding this comment.
Probably it could just be extracted out to a separate method?
There was a problem hiding this comment.
In this case IMO it's more readable like this, I don't want to add more methods for this because it's going to be moved for #21029.
dsherret
approved these changes
Jan 2, 2024
Comment on lines
+1070
to
+1073
| if let Some(config_file) = self.config.maybe_config_file() { | ||
| if let Ok((compiler_options, _)) = config_file.to_compiler_options() { | ||
| if let Some(compiler_options_obj) = compiler_options.as_object() { | ||
| if let Some(jsx_import_source) = |
There was a problem hiding this comment.
Probably it could just be extracted out to a separate method?
dsherret
reviewed
Jan 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #20582.
Fixes #21725.
When a
deno.jsonfile is loaded, readcompilerOptions.jsxImportSourceand queue a task to cache it.