fix(net): set correct max size for Datagram #21611
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
billywhizz
commented
Dec 17, 2023
ext/net/01_net.js
Outdated
| @@ -385,6 +387,11 @@ class Datagram { | |||
| async send(p, opts) { | |||
| switch (this.addr.transport) { | |||
| case "udp": | |||
| if (p.length > UDP_DGRAM_MAXSIZE) { | |||
There was a problem hiding this comment.
we could just take this check out and leave the PR with the change above. if we try to send with a payload greater than whatever the OS allows (it seems macs define a much lower max size by default and CI is failing) we will throw back a system error. i can modify the test to handle this correctly.
littledivy
reviewed
Dec 18, 2023
littledivy
reviewed
Dec 18, 2023
|
if there is anything you need me to do to get this landed please shout. maybe it has been fixed elsewhere? |
|
@billywhizz Sorry for the late reviews. This looks good, can you rebase? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #21609