Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add notebook support to the language server #21518

Closed
wants to merge 2 commits into from
Closed

Conversation

zebreus
Copy link
Contributor

@zebreus zebreus commented Dec 8, 2023

I started tinkering around with adding notebook support to the deno language server. Still WIP

@CLAassistant
Copy link

CLAassistant commented Dec 8, 2023

CLA assistant check
All committers have signed the CLA.

@bartlomieju
Copy link
Member

Hey @zebreus, thanks for opening the Pull Request. Could you give us some context here on what you're trying to achieve. We can definitely help and provide pointers.

@ceifa
Copy link

ceifa commented May 3, 2024

@zebreus are you still working on this one?

@zebreus
Copy link
Contributor Author

zebreus commented May 4, 2024

I am no longer working on this PR.

If I remember correctly, the Deno language server does not have proper notebook support but treats every cell like a separate document. This is the default fallback mechanism for notebooks if the language server does not support notebooks. That behavior causes some problems; for example, the type of variables from the previous cell is unknown in the subsequent cells. Fixing this would require the language server to treat all cells as a single file, but that would come with other issues, as the cells are not necessarily executed from top to bottom. However, that would still be more useful than the current implementation. Afaik, no language server for a statically typed language currently has good support for notebooks.

The language server protocol supports notebooks, but we need tower-lsp to do the same. I opened a PR over there (ebkalderon/tower-lsp#401), but that is blocked by gluon-lang/lsp-types#266, which is blocked by gluon-lang/lsp-types#266.

I am closing this PR because I have given up on using deno for notebooks.

@zebreus zebreus closed this May 4, 2024
@bartlomieju
Copy link
Member

@zebreus thanks for the update.

I am closing this PR because I have given up on using deno for notebooks.

Was there particular reason you gave up?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants