Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(napi): add napi_async_init and napi_async_destroy #19234

Merged
merged 3 commits into from
May 24, 2023

Conversation

bartlomieju
Copy link
Member

@bartlomieju bartlomieju commented May 23, 2023

We don't have support for "AsyncContext" in "node:async_hooks"
module, so these two APIs are just noops.

Towards #18610.

@bartlomieju bartlomieju requested a review from littledivy May 23, 2023 21:08
@bartlomieju bartlomieju marked this pull request as ready for review May 24, 2023 12:05
@bartlomieju bartlomieju changed the title test: add test for napi_async_init and napi_async_destroy fix(napi): add napi_async_init and napi_async_destroy May 24, 2023
@bartlomieju bartlomieju merged commit e56695d into denoland:main May 24, 2023
@bartlomieju bartlomieju deleted the napi_async_work_tests branch May 24, 2023 13:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants