Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: use v8::String::new_external_onebyte_static where appropriate #18051

Merged
merged 2 commits into from
Mar 6, 2023
Merged

refactor: use v8::String::new_external_onebyte_static where appropriate #18051

merged 2 commits into from
Mar 6, 2023

Conversation

bartlomieju
Copy link
Member

No description provided.

aapoalas
aapoalas approved these changes Mar 6, 2023
View reviewed changes
Copy link
Collaborator

@aapoalas aapoalas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! I hadn't even realized that we had external string resource bindings.

core/bindings.rs Outdated Show resolved Hide resolved
littledivy
littledivy reviewed Mar 6, 2023
View reviewed changes
Copy link
Member

@littledivy littledivy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@bartlomieju bartlomieju enabled auto-merge (squash) March 6, 2023 16:12
@bartlomieju bartlomieju merged commit 489cafd into denoland:main Mar 6, 2023
@bartlomieju bartlomieju deleted the use_external_strings branch March 6, 2023 16:40
@20k-ultra 20k-ultra mentioned this pull request Mar 6, 2023
Closed
3 tasks
kt3k pushed a commit that referenced this pull request Mar 10, 2023
@bartlomieju @kt3k
refactor: use v8::String::new_external_onebyte_static where appropria…
91ea2cd 
…te (#18051)
@Brooooooklyn Brooooooklyn mentioned this pull request Jun 1, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@littledivy littledivy littledivy approved these changes

@aapoalas aapoalas aapoalas approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@bartlomieju @aapoalas @littledivy