Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(ext/node): cleanup empty internal_bindings #18032

Merged
merged 1 commit into from
Mar 5, 2023

Conversation

littledivy
Copy link
Member

No description provided.

Copy link
Member

@bartlomieju bartlomieju left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

IIRC these modules are actually reachable from user code - removing them might (and possibly will) break compatibility with existing packages

@littledivy
Copy link
Member Author

IIRC these modules are actually reachable from user code

Can you give an example? I thought internalBinding calls in Node was supposed to be completely isolated from users.

@bartlomieju
Copy link
Member

I might have messed it up, there's this API:
https://github.com/nodejs/node/blob/7e6bc93add1e5b8e9ede20354b098d6ebceeeaf4/lib/internal/bootstrap/loaders.js#L232-L241

But I think it's only about internal/ modules, not internalBindings. Could you double check it?

@littledivy
Copy link
Member Author

sheesh - ok so that code was a mess but I found this issue: nodejs/node#27061 internal_bindings are not accessible from userland. It's very sus if a module is using it somehow (just like Deno.core)

@littledivy littledivy enabled auto-merge (squash) March 5, 2023 13:20
@littledivy littledivy merged commit c9c7829 into denoland:main Mar 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants