Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(test): add slice method to filename #16482

Merged
merged 2 commits into from
Oct 31, 2022
Merged

fix(test): add slice method to filename #16482

merged 2 commits into from
Oct 31, 2022

Conversation

shogohida
Copy link
Contributor

@shogohida shogohida commented Oct 30, 2022 •
edited
Loading

@CLAassistant
Copy link

CLAassistant commented Oct 30, 2022 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

@shogohida shogohida marked this pull request as ready for review October 30, 2022 06:59
@shogohida shogohida changed the title fix(test): add slice to filename fix(test): add slice method to filename Oct 30, 2022
@shogohida shogohida mentioned this pull request Oct 30, 2022
Closed
@magurotuna magurotuna self-requested a review October 30, 2022 15:57
magurotuna
magurotuna approved these changes Oct 31, 2022
View reviewed changes
Copy link
Member

@magurotuna magurotuna left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - Good fix :) Thanks for your first contribution!

@magurotuna magurotuna merged commit 80ed54a into denoland:main Oct 31, 2022
@shogohida shogohida deleted the add-slice-to-filename branch October 31, 2022 04:44
@shogohida
Copy link
Contributor Author

Thanks for approving my PR! Your support helped me a lot! Hope to contribute more!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@magurotuna magurotuna magurotuna approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

A few test cases fail if the project directory is located in a deep place
3 participants
@shogohida @CLAassistant @magurotuna