Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor(runtime/io): use primordials #15906

Merged
merged 2 commits into from
Sep 15, 2022
Merged

refactor(runtime/io): use primordials #15906

merged 2 commits into from
Sep 15, 2022

Conversation

marcosc90
Copy link
Contributor

Ref #11224

@CLAassistant
Copy link

CLAassistant commented Sep 14, 2022 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

ghost
ghost approved these changes Sep 14, 2022
View reviewed changes
Copy link

@ghost ghost left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Misleading title, but changes are good; the CLI is failing because of flash HTTP failures, which seem unrelated.

@littledivy littledivy merged commit 606a6d7 into denoland:main Sep 15, 2022
@marcosc90 marcosc90 deleted the refactor-io-primordials branch September 15, 2022 08:15
cjihrig pushed a commit that referenced this pull request Sep 15, 2022
@marcosc90 @cjihrig
refactor(runtime/io): use primordials (#15906)
a253ec4
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@littledivy littledivy littledivy approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@marcosc90 @CLAassistant @littledivy