Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(npm): conditional exports with wildcards #15652

Merged
merged 6 commits into from
Aug 29, 2022
Merged

fix(npm): conditional exports with wildcards #15652

merged 6 commits into from
Aug 29, 2022

Conversation

bartlomieju
Copy link
Member

@bartlomieju bartlomieju commented Aug 28, 2022 •
edited
Loading

Closes #15605

Need to add a test.

Unfortunately it doesn't completely fix the problem as now we get missing export:

error: Uncaught SyntaxError: The requested module '@azure/core-util' does not provide an export named 'isObjectWithProperties'
    at <anonymous> (file:///Users/ib/Library/Caches/deno/npm/registry.npmjs.org/@azure/notification-hubs/1.0.0-beta.2/dist-esm/src/auth/sasTokenProvider.js:4:10)

CC @dsherret

@bartlomieju bartlomieju changed the title [WIP] fix(npm): conditional exports with wildcards fix(npm): conditional exports with wildcards Aug 29, 2022
dsherret
dsherret approved these changes Aug 29, 2022
View reviewed changes
Copy link
Member

@dsherret dsherret left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@bartlomieju bartlomieju merged commit 2851a98 into denoland:main Aug 29, 2022
@bartlomieju bartlomieju deleted the npm_fix_conditional_exports branch August 29, 2022 17:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dsherret dsherret dsherret approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

npm throws on subpath exports mapping
2 participants
@bartlomieju @dsherret