Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(cli/dts): allow passing arguments to WebAssembly error constructors #15149

Merged
merged 1 commit into from
Jul 14, 2022
Merged

fix(cli/dts): allow passing arguments to WebAssembly error constructors #15149

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions cli/dts/lib.deno.shared_globals.d.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,7 @@ declare namespace WebAssembly {
*/
export class CompileError extends Error {
/** Creates a new `WebAssembly.CompileError` object. */
constructor();
constructor(message?: string, options?: ErrorOptions);
Copy link
Member

@dsherret dsherret Jul 12, 2022 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks like there are additional signatures as well: https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Global_Objects/WebAssembly/CompileError/CompileError

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I didn't include those ones because they're non-standard; do you want to include then anyway?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh, you're right. I didn't notice.

}

/**
Expand Down Expand Up @@ -72,7 +72,7 @@ declare namespace WebAssembly {
*/
export class LinkError extends Error {
/** Creates a new WebAssembly.LinkError object. */
constructor();
constructor(message?: string, options?: ErrorOptions);
dsherret marked this conversation as resolved.
Show resolved Hide resolved
}

/**
Expand Down Expand Up @@ -132,7 +132,7 @@ declare namespace WebAssembly {
*/
export class RuntimeError extends Error {
/** Creates a new `WebAssembly.RuntimeError` object. */
constructor();
constructor(message?: string, options?: ErrorOptions);
dsherret marked this conversation as resolved.
Show resolved Hide resolved
}

/**
Expand Down