Move console to console.ts and better stringify #141
Conversation
|
|
console.ts
Outdated
|
|
||
| const _print = V8Worker2.print; | ||
|
|
||
| export class DConsole { |
There was a problem hiding this comment.
I added it to suppress a warning of my editor. Should have removed it, will do right away
console.ts
Outdated
| return out.join(" "); | ||
| } | ||
|
|
||
| const _print = V8Worker2.print; |
There was a problem hiding this comment.
Same as above (seems to be considered as print in browser)
console.ts
Outdated
|
|
||
| debug = this.log; | ||
| info = this.log; | ||
| dirxml = this.log; |
console.ts
Outdated
| @@ -0,0 +1,82 @@ | |||
| class ConsoleContext { | |||
There was a problem hiding this comment.
why not
type ConsoleContext = Set<any>;
There was a problem hiding this comment.
Not quite sure if there would be any more fields added to the ConsoleContext, so I left it that way so could later introduce new props if necessary. Could change to type though
kevinkassimo
force-pushed
the
feat-consoles
branch
from
72e7dad to
846fd2b
Compare
|
Thanks. Completed splitting the original commits to multiple, removing console.dirxml, changing ConsoleContext. |
kevinkassimo
force-pushed
the
feat-consoles
branch
from
547f710 to
70457c2
Compare
|
Improved log format of functions, symbols, and class instances. |
kevinkassimo
force-pushed
the
feat-consoles
branch
from
4ff0521 to
05a8fd1
Compare
kevinkassimo
force-pushed
the
feat-consoles
branch
from
05a8fd1 to
a180acb
Compare
|
@ry Noticed that this PR has been held for quite a while. I can probably close it if it is not important for now |
|
@kevinkassimo Will get to it tomorrow - sorry for the delay! |
|
@kevinkassimo Thank you! It's a real improvement to the code base. And apologies again for slow response. |
Moving console definition to own file
console.tsand make it a class.Replaced
JSON.stringify()with customstringify()to avoid crashing on circular objects and work with methods/functions by displaying[Function].Add some aliases to already implemented console methods.