refactor(lsp): store assets behind a mutex #13414
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dsherret
changed the title
dsherret
commented
Jan 18, 2022
| specifier: &ModuleSpecifier, | ||
| // todo(dsherret): this shouldn't be a parameter, but instead retrieved via | ||
| // a constructor dependency | ||
| get_snapshot: impl Fn() -> LspResult<Arc<StateSnapshot>>, |
There was a problem hiding this comment.
In a future PR, I'm hoping to get rid of this parameter and not have language_server::Inner passed around in other functions.
bartlomieju
reviewed
Jan 18, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR stores all assests behind a mutex in order to make more language server messages not require mutability.
This is possible to do because the assets are static and it is ok if two threads race to retrieve a non-cached asset from tsc.
This is slowly moving towards #11307.