feat: add "unhandledrejection" event support #12994

bartlomieju · 2021-12-05T05:48:04Z

This commit adds support for "unhandledrejection" event.

This event will trigger event listeners registered using:

"globalThis.addEventListener("unhandledrejection")
"globalThis.onunhandledrejection"

This is done by registering a default handler using
"Deno.core.setPromiseRejectCallback" that allows to
handle rejected promises in JavaScript instead of Rust.

This commit will make it possible to polyfill
"process.on("unhandledRejection")" in the Node compat
layer.

Closes #7013

bnoordhuis

Thanks for doing this, Bartek! The test failures are probably (hopefully) a small matter of updating test expectations.

bnoordhuis · 2021-12-05T09:52:52Z

ext/web/02_event.js

+    // TODO(lucacasonato): remove when this interface is spec aligned
+    [SymbolToStringTag] = "PromiseRejectionEvent";


For my understanding: what is the misalignment here? cc @lucacasonato

The entire eventing system has not been migrated to use our webidl helper classes yet. It is on my backburner.

runtime/js/99_main.js

bartlomieju · 2021-12-05T12:16:41Z

Thanks for doing this, Bartek! The test failures are probably (hopefully) a small matter of updating test expectations.

I think there's quite more to do before this PR will be ready to merge. Just wanted to get ball rolling for now.

bartlomieju · 2021-12-07T13:29:09Z

Discussed with @bnoordhuis offline, we're punting this PR for now as it's not clear how this functionality would integrate with Node compatibility layer. Ben will first implement process.on("unhandledRejection", ...) in deno_std/node.

lucsoft · 2021-12-07T13:50:57Z

Does this PR not implement document.addEventListener("unhandledrejection")?

bartlomieju · 2021-12-07T13:51:43Z

Does this PR not implement document.addEventListener("unhandledrejection")?

It does implement it.

Skillz4Killz · 2021-12-17T15:30:18Z

As a reminder, it is incredibly useful to some people to be able to make sure this can be used to prevent a process from crashing in production.

hashemisa · 2022-01-27T16:41:37Z

What version should we wait for this possibility?

stale · 2022-03-29T01:06:21Z

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed in 7 days if no further activity occurs. Thank you for your contributions.

jiawei397 · 2022-06-11T13:18:28Z

Do you have any plans to merge this submission?

bartlomieju · 2022-06-12T22:44:43Z

Do you have any plans to merge this submission?

Yes, but it hasn't been the highest priority.

jiawei397 · 2022-06-14T13:12:17Z

Do you have any plans to merge this submission?

Yes, but it hasn't been the highest priority.

OK, I will continue to pay attention to this. Thanks for your reply.

kitsonk

LGTM

bartlomieju · 2022-07-04T16:14:03Z

~~Note to self: add test for when promise rejects with "undefined" to check that "reason" on the event is actually "undefined" instead of "null".~~

Done

lucacasonato

LGTM!

This reverts commit f7af0b0.

This commit adds support for "unhandledrejection" event. This event will trigger event listeners registered using: "globalThis.addEventListener("unhandledrejection") "globalThis.onunhandledrejection" This is done by registering a default handler using "Deno.core.setPromiseRejectCallback" that allows to handle rejected promises in JavaScript instead of Rust. This commit will make it possible to polyfill "process.on("unhandledRejection")" in the Node compat layer. Co-authored-by: Colin Ihrig <[email protected]>

Relanding #12994 This commit adds support for "unhandledrejection" event. This event will trigger event listeners registered using: "globalThis.addEventListener("unhandledrejection") "globalThis.onunhandledrejection" This is done by registering a default handler using "Deno.core.setPromiseRejectCallback" that allows to handle rejected promises in JavaScript instead of Rust. This commit will make it possible to polyfill "process.on("unhandledRejection")" in the Node compat layer. Co-authored-by: Colin Ihrig <[email protected]>

…denoland#15080)" This reverts commit 1a7259b.

…" (#15210) This reverts commit 1a7259b.

…d#12994) (denoland#15080)" (denoland#15210)" This reverts commit f9b692e.

bartlomieju added 2 commits December 5, 2021 06:47

feat: add window.onunhandledrejection

8e87e26

make cancellable

a6707a6

bnoordhuis approved these changes Dec 5, 2021

View reviewed changes

throw reason

8fbab67

bartlomieju added this to the 1.18.0 milestone Dec 7, 2021

bartlomieju removed this from the 1.18.0 milestone Jan 16, 2022

stale bot added the stale label Mar 29, 2022

stale bot closed this Apr 6, 2022

bartlomieju reopened this Apr 7, 2022

stale bot removed the stale label Apr 7, 2022

Merge branch 'main' into unhandledrejections

09b36af

bartlomieju requested review from crowlKats and kitsonk as code owners April 12, 2022 19:09

bartlomieju added 2 commits April 12, 2022 21:18

lint

66fd2e7

Merge branch 'main' into unhandledrejections

7fd8b07

Merge branch 'main' into unhandledrejections

1ed9ee5

bartlomieju force-pushed the unhandledrejections branch from 1af80b2 to 1ed9ee5 Compare June 21, 2022 23:22

bartlomieju added 3 commits June 22, 2022 01:37

fix op name

e5b3e18

Debug

933175e

move logic from Rust to JavaScript

5f73ffc

bartlomieju added 4 commits June 28, 2022 21:46

remove debug logs

533b09a

expose PromiseRejectionEvent

d16645d

wip

9ce53cb

add a test

482a3f7

bartlomieju force-pushed the unhandledrejections branch from e89ff22 to 482a3f7 Compare June 28, 2022 21:53

bartlomieju changed the title ~~[WIP] feat: add window.onunhandledrejection~~ feat: add window.onunhandledrejection Jun 28, 2022

bartlomieju added 4 commits June 29, 2022 00:02

lint

a8d081b

forward promise rejections to Rust if not handled

34d185d

apply callback in worker, remove stale comment

a98a890

Merge branch 'main' into unhandledrejections

4ccfcc1

bartlomieju changed the title ~~feat: add window.onunhandledrejection~~ feat: add "unhandledrejection" event support Jun 28, 2022

reset CI

b171a4c

kitsonk approved these changes Jul 4, 2022

View reviewed changes

bartlomieju added 2 commits July 4, 2022 17:26

Merge branch 'main' into unhandledrejections

6d6050b

fixed timing and null in reason

31a108b

bartlomieju force-pushed the unhandledrejections branch from 25428a0 to 31a108b Compare July 4, 2022 16:12

add test

28a3183

lucacasonato approved these changes Jul 4, 2022

View reviewed changes

bartlomieju merged commit f7af0b0 into denoland:main Jul 4, 2022

bartlomieju deleted the unhandledrejections branch July 4, 2022 19:15

bartlomieju mentioned this pull request Jul 4, 2022

onunhandledrejection for globalThis? #7013

Closed

bartlomieju added a commit to bartlomieju/deno that referenced this pull request Jul 4, 2022

Revert "feat: add "unhandledrejection" event support (denoland#12994)"

23b2746

This reverts commit f7af0b0.

bartlomieju added a commit that referenced this pull request Jul 4, 2022

Revert "feat: add "unhandledrejection" event support (#12994)" (#15075)

06934db

This reverts commit f7af0b0.

bartlomieju mentioned this pull request Jul 5, 2022

feat: add "unhandledrejection" event support (#12994) #15080

Merged

bartlomieju added a commit to bartlomieju/deno that referenced this pull request Jul 14, 2022

Revert "feat: add "unhandledrejection" event support (denoland#12994) (…

dba4268

…denoland#15080)" This reverts commit 1a7259b.

bartlomieju added a commit that referenced this pull request Jul 14, 2022

Revert "feat: add "unhandledrejection" event support (#12994) (#15080)…

f9b692e

…" (#15210) This reverts commit 1a7259b.

bartlomieju added a commit to bartlomieju/deno that referenced this pull request Jul 15, 2022

Revert "Revert "feat: add "unhandledrejection" event support (denolan…

d0d8e1c

…d#12994) (denoland#15080)" (denoland#15210)" This reverts commit f9b692e.

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat: add "unhandledrejection" event support #12994

feat: add "unhandledrejection" event support #12994

bartlomieju commented Dec 5, 2021 •

edited

Loading

bnoordhuis left a comment

bnoordhuis Dec 5, 2021

lucacasonato Dec 7, 2021

bartlomieju commented Dec 5, 2021

bartlomieju commented Dec 7, 2021

lucsoft commented Dec 7, 2021 •

edited

Loading

bartlomieju commented Dec 7, 2021

Skillz4Killz commented Dec 17, 2021

hashemisa commented Jan 27, 2022

stale bot commented Mar 29, 2022

jiawei397 commented Jun 11, 2022

bartlomieju commented Jun 12, 2022

jiawei397 commented Jun 14, 2022

kitsonk left a comment

bartlomieju commented Jul 4, 2022 •

edited

Loading

lucacasonato left a comment

		// TODO(lucacasonato): remove when this interface is spec aligned
		[SymbolToStringTag] = "PromiseRejectionEvent";

feat: add "unhandledrejection" event support #12994

feat: add "unhandledrejection" event support #12994

Conversation

bartlomieju commented Dec 5, 2021 • edited Loading

bnoordhuis left a comment

Choose a reason for hiding this comment

bnoordhuis Dec 5, 2021

Choose a reason for hiding this comment

lucacasonato Dec 7, 2021

Choose a reason for hiding this comment

bartlomieju commented Dec 5, 2021

bartlomieju commented Dec 7, 2021

lucsoft commented Dec 7, 2021 • edited Loading

bartlomieju commented Dec 7, 2021

Skillz4Killz commented Dec 17, 2021

hashemisa commented Jan 27, 2022

stale bot commented Mar 29, 2022

jiawei397 commented Jun 11, 2022

bartlomieju commented Jun 12, 2022

jiawei397 commented Jun 14, 2022

kitsonk left a comment

Choose a reason for hiding this comment

bartlomieju commented Jul 4, 2022 • edited Loading

lucacasonato left a comment

Choose a reason for hiding this comment

bartlomieju commented Dec 5, 2021 •

edited

Loading

lucsoft commented Dec 7, 2021 •

edited

Loading

bartlomieju commented Jul 4, 2022 •

edited

Loading