Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enhance README.md #129

Closed
wants to merge 1 commit into from
Closed

Enhance README.md #129

wants to merge 1 commit into from

Conversation

liyuhang1997
Copy link

Summary

This PR is to enhance the README with following three points:

  1. Fix typo.
  2. Delete unnecessary blank lines.
  3. Delete unnecessary spaces between ``` and the language name bash.
  4. Add some blank lines. Fenced code blocks should be surrounded by blank lines.

@CLAassistant
Copy link

CLAassistant commented Jun 4, 2018 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

@kitsonk
Copy link
Contributor

kitsonk commented Jun 4, 2018

Segaulty is likely intentional, indicating an attribute of the current state of the code versus a noun. While it isn't the most internationally English term, it is technically accurate.

ry
ry reviewed Jun 5, 2018
View reviewed changes
README.md

## Status

Segfaulty.
Segfault.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

segfaulty is intended

@ry
Copy link
Member

ry commented Jun 5, 2018

Thanks for the adjustments but the readme is fine as is for now

@ry ry closed this Jun 5, 2018
piscisaureus pushed a commit to piscisaureus/deno that referenced this pull request Oct 7, 2019
@ry
testing: Don't automatically run on import (denoland#129)
ec1675a
@MarkTiedemann MarkTiedemann mentioned this pull request Jun 26, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ry ry ry left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@liyuhang1997 @CLAassistant @kitsonk @ry