Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: remove credentials typings from fetch #12384

Closed
wants to merge 1 commit into from

Conversation

crowlKats
Copy link
Member

Deno doesn't handle the credentials option, so the inclusion of typings is miss-informing. Also in the case of Request's readonly credentials property, which isnt set at all, deno's behaviour conflicts with the typings

@MierenManz
Copy link

wouldn't this technically be a breaking change?

@lucacasonato
Copy link
Member

This makes Deno less compatible with ts code targeting browsers and Deno so we won't land it. Thanks though 🙂

@crowlKats
Copy link
Member Author

crowlKats commented Oct 9, 2021

one problem though is we dont set the reaedonly credentials property, so its undefined when accessed, which doesnt match typings at all

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants