Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(core): implement Deno.core.isProxy() #12288

Merged
merged 3 commits into from
Oct 1, 2021

Conversation

AaronO
Copy link
Contributor

@AaronO AaronO commented Oct 1, 2021

Another binding ... but it's required for #12286 and could be useful elsewhere

core.getProxyDetails(...) isn't fast enough for fast-path checks:

No fast path:
resp_w_bh:               n = 1000000, dt = 1.295s, r = 772201/s, t = 1294ns/op
Fast path with getProxyDetails check:
resp_w_bh:               n = 1000000, dt = 1.321s, r = 757002/s, t = 1321ns/op
Fast path with isProxy check:
resp_w_bh:               n = 1000000, dt = 1.146s, r = 872600/s, t = 1146ns/op
Forced fast path:
resp_w_bh:               n = 1000000, dt = 1.112s, r = 899281/s, t = 1112ns/op

Another binding ... but it's required for denoland#12286 and could be useful elsewhere
Copy link
Member

@bartlomieju bartlomieju left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks ok, but can you add a test before landing?

@AaronO AaronO merged commit 26de516 into denoland:main Oct 1, 2021
@AaronO AaronO deleted the feat/core-isProxy branch October 1, 2021 18:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants